https://bugzilla.redhat.com/show_bug.cgi?id=2040728 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fedora@xxxxxxxxxx | |) | |needinfo?(fedora@xxxxxxxxxx | |) | Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxx Status|NEW |ASSIGNED --- Comment #6 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Patch0: xtrkcad-5.2.2GA-p0.patch > Patch1: xtrkcad-5.2.2GA-p1.patch > Patch2: xtrkcad-5.2.2GA-p2.patch These should be either given some more descriptive names, or some comments explaining why they're needed. > Patch1: xtrkcad-5.2.2GA-p1.patch Don't. The license text should be included verbatim. Please submit this patch upstream and drop it from the SRPM. > mkdir -p %{buildroot}/%{_datadir}/pixmaps > mv %{buildroot}/%{_datadir}/%{name}/pixmaps/xtrkcad.png \ > %{buildroot}/%{_datadir}/pixmaps/xtrkcad.png 1. Consider using tabs or spaces to make follow-up lines more prominent when splitting commands across multiple lines. 2. This leaves behind the empty "%{buildroot}/%{_datadir}/%{name}/pixmaps/" directory. Remove it. The package allows building documentation using doxygen - consider doing this and putting documentation in a sub-package. If you add "BuildRequires: doxygen" and change "%cmake" to "%cmake -DXTRKCAD_USE_DOXYGEN", you will end up with the documentation installed in "%{buildroot}%{_datadir}/%{name}/html". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2040728 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
