https://bugzilla.redhat.com/show_bug.cgi?id=2049808 --- Comment #2 from David Duncan <davdunc@xxxxxxxxxx> --- (In reply to Michel Alexandre Salim from comment #1) > This depends on awscrt, marked it as a blocker. Meanwhile: > > - why rename this to awscli-2 ? If the intention is that both are parallel > installable, this should not obsolete the other. If not, then you can just > call this awscli (and actually, don't need a review request) it's a separate package. We have to maintain the original awscli package because it is in RHEL and needs to stay consistent for the foreseeable future. We will need to maintain the two tracks because they function in very different ways. > - missing %license LICENSE.txt whoops! > - with auto build requirement, you only need python3-devel. Drop toml and > wheel, they should be automatically picked up > - drop python_provide, it's deprecated: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_deprecated_macros Thank you. some careless copying of old process. > - there are tests, you probably want a %check section. If invoking %tox is > too much of a work, invoking %pytest should work. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests I think kyle can figure this out for me. Thanks. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2049808 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
