https://bugzilla.redhat.com/show_bug.cgi?id=2049808 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(davdunc@xxxxxxxxx | |m) --- Comment #1 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- This depends on awscrt, marked it as a blocker. Meanwhile: - why rename this to awscli-2 ? If the intention is that both are parallel installable, this should not obsolete the other. If not, then you can just call this awscli (and actually, don't need a review request) - missing %license LICENSE.txt - with auto build requirement, you only need python3-devel. Drop toml and wheel, they should be automatically picked up - drop python_provide, it's deprecated: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_deprecated_macros - there are tests, you probably want a %check section. If invoking %tox is too much of a work, invoking %pytest should work. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2049808 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
