[Bug 2048261] Review Request: pgadmin4 - Administration tool for PostgreSQL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2048261



--- Comment #10 from Sandro Mani <manisandro@xxxxxxxxx> ---
Thanks for the detailed feedback:

> - You appear to have disabled webpack optimisation. This was long ago found to be essential for acceptable performance of such a large web-based application.

This applies only to i686 and armv7hl (and armv7hl is actually scheduled for
retirement). I have to admit I gave up trying to get the Webpack terser plugin
to run through without stack exhaustion on these arches. Perhaps ExcludeArch
would have been the better choice.

> - config.py has been modified. That should never be done; create a config_distro.py instead in the same directory (see https://www.pgadmin.org/docs/pgadmin4/development/config_py.html#config-py)

I've since dropped all changes to config.py except for the help path, but I'll
look at handling this one properly as well

> - The custom runtime is missing configuration options requested by users, and documented in the docs and on the website, such as the log viewer which we ask users to use if they run into issues, and options for things like a fixed port number. See https://www.pgadmin.org/docs/pgadmin4/development/desktop_deployment.html#configuration

> - The NWjs runtime is controlled in places from the application code. There is no support for this in your runtime that I can see, so that functionality is almost certainly broken in a way that users won't expect.

Thanks I'll look into these as well

I've since made changes to the custom runtime explicitly noting in the window
title and the startup splash screen that it is an unofficial runtime. I've also
moved it to a separate subpackage. Is this acceptable to you? I can also add an
explicit popup informing the user that it is not an official runtime and that
bugs need to be filed in distro issue tracker.

As for webpack, I'd go for ExcludeArch.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2048261
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux