https://bugzilla.redhat.com/show_bug.cgi?id=2048261 Dave Page <dave.page@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dave.page@xxxxxxxxxxxxxxxx --- Comment #9 from Dave Page <dave.page@xxxxxxxxxxxxxxxx> --- Hi, pgAdmin dev here: - You appear to have disabled webpack optimisation. This was long ago found to be essential for acceptable performance of such a large web-based application. - config.py has been modified. That should never be done; create a config_distro.py instead in the same directory (see https://www.pgadmin.org/docs/pgadmin4/development/config_py.html#config-py) - We originally used QtWebEngine for the desktop runtime, but stopped doing so because of serious peformance issues. - As noted above, the SECRET_KEY was a serious security problem, but I see you have now resolved that. - The custom runtime is missing configuration options requested by users, and documented in the docs and on the website, such as the log viewer which we ask users to use if they run into issues, and options for things like a fixed port number. See https://www.pgadmin.org/docs/pgadmin4/development/desktop_deployment.html#configuration - The NWjs runtime is controlled in places from the application code. There is no support for this in your runtime that I can see, so that functionality is almost certainly broken in a way that users won't expect. In short, whilst I wouldn't complain if there were some minor tweaks to the code (unless something obviously broke documented functionality), the use of a custom runtime and potential performance regressions is likely to lead to user confusion and complaints that the pgAdmin Team will most likely receive in the first instance and be unable to help with. We would therefore request that you either rename the package so it is abundantly clear that it is not an official pgAdmin release, or revert the changes to the webpack configuration and use our standard runtime code. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2048261 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
