[Bug 2033891] Review Request: elementary-mail - Mail app designed for elementary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2033891



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Updated to version 6.4.0:

Spec URL: https://decathorpe.fedorapeople.org/packages/elementary-mail.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/elementary-mail-6.4.0-1.fc35.src.rpm

Note that recent Vala changes break compilation of this package on rawhide:
https://github.com/elementary/mail/issues/762
It compiles fine on f35 and f34, but I'll include a fix for rawhide here as
soon as upstream makes it available.

(In reply to Christopher Crouse from comment #2)
> - If your application is a C or C++ application you must list a
>   BuildRequires against gcc, gcc-c++ or clang.
>   Note: No gcc, gcc-c++ or clang found in BuildRequires
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
> 
>   OK: The vala package pulls in the gcc dependency. 
>   
>   Still according to the guidelines it is recommended to include in the spec:
>   BuildRequires: gcc

I don't think this is necessary.
If gala ever does not pull in gcc as a dependency, it will not work at all, so
that would be a bug in the vala package.

> - This package also has a problem with NxN@2 scaled icons in
> hicolor-icon-theme.
>   Bug discussion here: https://bugzilla.redhat.com/show_bug.cgi?id=2033890#c6

Done.

> - It is possible to provide translated versions of the description and
> summary in the spec file, since it is included in the AppData file settings.

As far as I know, those translations are not even used anywhere. GNOME Software
etc. will use the values from appdata and the .desktop file directly, no need
to include them in the .spec file.

> - Unversioned so file: `libio.elementary.mail-webkit-extension.so`
>   
>  
> /usr/lib64/io.elementary.mail/webkit2/libio.elementary.mail-webkit-extension.
> so
> 
>   Updating the `__provides_exclude_from` to the following in the spec should
> fix it:
> 
>   %global __provides_exclude_from ^%{_libdir}/%{appname}/*/.*\\.so$

Updated.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2033891
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux