https://bugzilla.redhat.com/show_bug.cgi?id=2033891 --- Comment #2 from Christopher Crouse <mail@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ OK: The vala package pulls in the gcc dependency. Still according to the guidelines it is recommended to include in the spec: BuildRequires: gcc - Dist tag is present. OK: rpmautospec - This package also has a problem with NxN@2 scaled icons in hicolor-icon-theme. Bug discussion here: https://bugzilla.redhat.com/show_bug.cgi?id=2033890#c6 Adding the same fix, in %install, as described in the bug discussion, example: "rm -r %{buildroot}/%{_datadir}/icons/hicolor/*@2/" - It is possible to provide translated versions of the description and summary in the spec file, since it is included in the AppData file settings. Related documentation here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description Example here: https://src.fedoraproject.org/rpms/appeditor/blob/8afdf490c0a7dbe84cb7887442c46bfdf2e311ef/f/appeditor.spec For example, in po/extras/de.po: #: data/io.elementary.mail.appdata.xml.in:9 #: data/io.elementary.mail.desktop.in:4 msgid "Send and receive mail" msgstr "Senden und Empfangen von Nachrichten" #: data/io.elementary.mail.appdata.xml.in:11 msgid "" "Mail is designed to let you manage your email quickly and effortlessly. Its " "interface is based on conversations, so you can read an entire discussion " "without having to click from message to message." msgstr "" "Mail wurde entwickelt, damit Sie Ihre E-Mails schnell und einfach verwalten " "können. Seine Benutzeroberfläche stellt Nachrichten in der " "Konversationsansicht dar, sodass Sie eine ganze Diskussion lesen können, " "ohne von einer Nachricht zur nächsten wechseln zu müssen." Regardless, this is optional, since in the guidelines it does not say you "SHOULD" do it. - Unversioned so file: `libio.elementary.mail-webkit-extension.so` /usr/lib64/io.elementary.mail/webkit2/libio.elementary.mail-webkit-extension.so Updating the `__provides_exclude_from` to the following in the spec should fix it: %global __provides_exclude_from ^%{_libdir}/%{appname}/*/.*\\.so$ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "GNU General Public License v3.0 or later", "GNU Lesser General Public License v3.0 or later". 403 files have unknown license. Detailed output of licensecheck in /home/amz/Downloads/2033891-elementary-mail/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/hicolor/64x64@2/apps, /usr/share/icons/hicolor/128x128@2, /usr/share/icons/hicolor/24x24@2, /usr/share/icons/hicolor/48x48@2, /usr/share/icons/hicolor/48x48@2/apps, /usr/share/icons/hicolor/16x16@2/apps, /usr/share/icons/hicolor/24x24@2/apps, /usr/share/icons/hicolor/16x16@2, /usr/share/locale/mo, /usr/share/icons/hicolor/32x32@2, /usr/share/icons/hicolor/128x128@2/apps, /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/32x32@2/apps, /usr/share/locale/mo/LC_MESSAGES [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/128x128@2, /usr/share/icons/hicolor/48x48@2, /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/32x32@2, /usr/share/icons/hicolor/24x24@2, /usr/share/icons/hicolor/32x32@2/apps, /usr/share/icons/hicolor/128x128@2/apps, /usr/share/locale/mo/LC_MESSAGES, /usr/share/icons/hicolor/24x24@2/apps, /usr/share/icons/hicolor/64x64@2/apps, /usr/share/icons/hicolor/16x16@2/apps, /usr/share/locale/mo, /usr/share/icons/hicolor/16x16@2, /usr/share/icons/hicolor/48x48@2/apps [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1044480 bytes in /usr/share Reviewer note: should be smaller if fix is implemented for the problematic NxN@2 scaled icons in hicolor-icon-theme [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- elementary-mail: /usr/lib64/io.elementary.mail/webkit2/libio.elementary.mail-webkit-extension.so Source checksums ---------------- https://github.com/elementary/mail/archive/6.3.1/elementary-mail-6.3.1.tar.gz : CHECKSUM(SHA256) this package : 984418a1a185c7212bc039ec4c53f5c8f48c3df9a0f087f96cb4e9cb61f92eb5 CHECKSUM(SHA256) upstream package : 984418a1a185c7212bc039ec4c53f5c8f48c3df9a0f087f96cb4e9cb61f92eb5 Requires -------- elementary-mail (rpmlib, GLIBC filtered): config(elementary-mail) hicolor-icon-theme libc.so.6()(64bit) libcamel-1.2.so.63()(64bit) libedataserver-1.2.so.26()(64bit) libedataserverui-1.2.so.3()(64bit) libfolks.so.26()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgee-0.8.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite.so.6()(64bit) libgtk-3.so.0()(64bit) libhandy-1.so.0()(64bit) libhandy-1.so.0(LIBHANDY_1_0)(64bit) libjavascriptcoregtk-4.0.so.18()(64bit) libsoup-2.4.so.1()(64bit) libwebkit2gtk-4.0.so.37()(64bit) rtld(GNU_HASH) elementary-mail-debuginfo (rpmlib, GLIBC filtered): elementary-mail-debugsource (rpmlib, GLIBC filtered): Provides -------- elementary-mail: application() application(io.elementary.mail.desktop) config(elementary-mail) elementary-mail elementary-mail(x86-64) metainfo() metainfo(io.elementary.mail.appdata.xml) mimehandler(x-scheme-handler/mailto) elementary-mail-debuginfo: debuginfo(build-id) elementary-mail-debuginfo elementary-mail-debuginfo(x86-64) libio.elementary.mail-webkit-extension.so-6.3.1-1.fc36.x86_64.debug()(64bit) elementary-mail-debugsource: elementary-mail-debugsource elementary-mail-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/bin/fedora-review -b 2033891 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, R, Ocaml, SugarActivity, Python, Perl, Haskell, PHP, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ==== rpmlint: 2.2.0 rpmlint elementary-mail-debuginfo-6.3.1-1.fc36.x86_64.rpm elementary-mail-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/elementary-mail-6.3.1-1.fc36.x86_64 elementary-mail-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/io.elementary.mail-6.3.1-1.fc36.x86_64.debug elementary-mail-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/io.elementary.mail/webkit2/libio.elementary.mail-webkit-extension.so-6.3.1-1.fc36.x86_64.debug elementary-mail-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/elementary-mail-6.3.1-1.fc36.x86_64 elementary-mail-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/io.elementary.mail-6.3.1-1.fc36.x86_64.debug elementary-mail-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/io.elementary.mail/webkit2/libio.elementary.mail-webkit-extension.so-6.3.1-1.fc36.x86_64.debug elementary-mail-debuginfo.x86_64: W: no-documentation elementary-mail-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/elementary-mail-6.3.1-1.fc36.x86_64 elementary-mail-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz elementary-mail-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz elementary-mail-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/b1/9bbe5cb2708c645aafbf048ecce413c7940b67 ../../../.build-id/b1/9bbe5cb2708c645aafbf048ecce413c7940b67 elementary-mail-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/e2/cb303baf57e3b5aa58e58f5bbe9ebfc9627862 ../../../.build-id/e2/cb303baf57e3b5aa58e58f5bbe9ebfc9627862 ==== -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033891 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
