https://bugzilla.redhat.com/show_bug.cgi?id=2044664 Bug ID: 2044664 Summary: Review Request: ROCm-Device-Libs - AMD ROCm LLVM bit code libraries Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: alexjnewt@xxxxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Spec URL: https://mystro256.fedorapeople.org/ROCm-Device-Libs.spec SRPM URL: https://mystro256.fedorapeople.org/ROCm-Device-Libs-4.5.2-1.fc36.src.rpm Description: This package contains a set of AMD specific device-side language runtime libraries in the form of bit code. Specifically: - Open Compute library controls - Open Compute Math library - Open Compute Kernel library - OpenCL built-in library - HIP built-in library - Heterogeneous Compute built-in library Fedora Account System Username: mystro256 Note this is a requirement for updating rocm-runtime to the latest (blocks RHBZ#1877523) rpmlint output: ROCm-Device-Libs.noarch: W: only-non-binary-in-usr-lib ROCm-Device-Libs.src:44: E: hardcoded-library-path in %{_prefix}/lib/cmake/AMDDeviceLibs ROCm-Device-Libs.src:45: E: hardcoded-library-path in %{_prefix}/lib/amdgcn See patch0, my gut says that we should put this in /usr/share, but upstream is insistent on using /usr/lib by default. I drafted the patch to propose to upstream if this package is accepted to allow flexibility in location. I started a thread about it on the devel mailing list, but I haven't gotten any response yet. I think /usr/lib would be fine since this is a noarch package and isn't required to split libdir between lib and lib64, but I don't mind putting it in /usr/share if need be. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2044664 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
