[Bug 2035671] Review Request: mrcpp - A general purpose numerical mathematics library based on multiresolution analysis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2035671



--- Comment #13 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Here’s a scratch build with s390x re-enabled:
https://koji.fedoraproject.org/koji/taskinfo?taskID=81362814

It’s not yet quite finished, but about half of the test executables are
failing.

The first place I would look to fix it would be the routines that read binary
data files, e.g.
https://github.com/MRChemSoft/mrcpp/blob/0e079a929794aa0c135c8016c9aa4995f3376c58/src/core/CrossCorrelation.cpp#L100.
There seem to be only a few of these based on grepping for std::ios::binary,
and removing the little-endian assumption in these might be enough to fix
s390x. Whether upstream would be receptive to a patch that adds complexity or
possibly has a small impact on performance is another question…


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2035671
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux