https://bugzilla.redhat.com/show_bug.cgi?id=2023307 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #9 from Petr Menšík <pemensik@xxxxxxxxxx> --- Looks great. I don't know how SuSE handles %cmake macro so I took a look at json-c [1]. It seems they use similar macro %cmake and %cmake_install, but have %cmake_build integrated into %cmake. Unless they define it special way, It might be possible to use: %build %cmake %{?cmake_build} %install %cmake_install This might work both on RHEL derivative and SUSE distributions without a change. If not, this would work for sure: %cmake %if 0%{?fedora} || 0%{?rhel} %cmake_build %endif I admit I build on various RHEL alternatives, but have not direct experience with RPM builds on SUSE. I think they should be reasonably close for basic things. I admit including build after %cmake configuration is nice and usually desired. I noticed just now. The package has Conflicts: libnetconf-devel, but such package does not exist in Fedora. I would recommend upgrading it instead if it existed. But it is not there and seems newer was. It does not seem to be present also in opensuse. Is it needed on any system? I would personally add a patch disabling only failing tests. Commenting them out in test summary for example. Also with including upstream bug link together with patch. It would remind you to fix tests on upgrade. If there are at least some passing tests, they should run. If they would not work under mockbuild, use %bcond_with check and %if %{with check}...%endif. But because that is only optional improvements, I am granting review+. Continue with fedpkg request-repo please. 1. https://build.opensuse.org/package/view_file/openSUSE:Factory/json-c/json-c.spec?expand=1 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2023307 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
