https://bugzilla.redhat.com/show_bug.cgi?id=2023307 --- Comment #8 from Jakub Ruzicka <jakub.ruzicka@xxxxxx> --- OK, I've updated the .spec in-place per your instructions: - use %cmake macros (-> different .spec for EL/SUSE :'( ) - drop make dep - better Source URL - include *.md docs using %doc - make -devel require pkgconfig Tests can be enabled by BR: pkgconfig(libcmocka) and %cmake -DENABLE_TESTS=ON, but they fail: 83% tests passed, 2 tests failed out of 12 The following tests FAILED: 8 - test_server_thread (Failed) 11 - test_client_ssh (Failed) I'll let upstream know about this, but for now I'm leaving tests disabled. Let me know if you find anything else worth improving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2023307 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
