https://bugzilla.redhat.com/show_bug.cgi?id=2040118 --- Comment #3 from Garry T. Williams <gtwilliams@xxxxxxxxx> --- (In reply to Artur Frenszek-Iwicki from comment #2) > > Source0: https://github.com/gtwilliams/deal/blob/master/deal-3.1.9.tar.gz > This URL fetches the latest commit from master and simply names the file > "deal-3.1.9.tar.gz". Noted and fixed. > > %global debug_package %{nil} > No-go. We want debuginfo in Fedora. I think I have this fixed. > Looking at the repo, you overwrite CPPLAGS in the Makefile with "CPPFLAGS = > -O3 -fPIE" > You can try the following instead: > 1. Call "%set_build_flags" at the start of %build to set Fedora's > CFLAGS/CXXFLAGS > 2. Use "+=" in the Makefile to append -fPIE instead of overwriting I chose the second; also added required -g in the same change. > > mkdir -p %{build_data}/input > > mkdir -p %{build_data}/format > > mkdir -p %{build_data}/lib > > mkdir -p %{build_data}/ex > > mkdir -p %{build_docs}/html > > mkdir -p %{build_docs}/graphics > > ... > > install -p -m 0644 input/* %{build_data}/input > > install -p -m 0644 format/* %{build_data}/format > > install -p -m 0644 lib/* %{build_data}/lib > > install -p -m 0644 ex/* %{build_data}/ex > > install -p -m 0644 docs/html/*.* %{build_docs}/html > > install -p -m 0644 docs/graphics/* %{build_docs}/graphics > Could you use "cp -a" here instead? Or, since the Source is a fork you > control, > consider adding an "install" target to the Makefile and just doing > %make_install. Understood. Since the original author didn't design an install target, I am choosing to leave the crude Makefile as is and I simplified the %install section as you suggested, using cp -a. Thank you for your review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2040118 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
