https://bugzilla.redhat.com/show_bug.cgi?id=2040118 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |fedora@xxxxxxxxxx --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Source0: https://github.com/gtwilliams/deal/blob/master/deal-3.1.9.tar.gz This URL fetches the latest commit from master and simply names the file "deal-3.1.9.tar.gz". This means that the contents of the file will change over time. You should either add a tag to the git repo, or refer a specific commit, like this: "Source0: %{url}/archive/%{git_tag_or_commit}/%{name}-%{git_tag_or_commit}.tar.gz" https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services Alternatively, you can use the forge macros to handle this for you. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control > %global debug_package %{nil} No-go. We want debuginfo in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ Looking at the repo, you overwrite CPPLAGS in the Makefile with "CPPFLAGS = -O3 -fPIE" You can try the following instead: 1. Call "%set_build_flags" at the start of %build to set Fedora's CFLAGS/CXXFLAGS 2. Use "+=" in the Makefile to append -fPIE instead of overwriting > mkdir -p %{build_data}/input > mkdir -p %{build_data}/format > mkdir -p %{build_data}/lib > mkdir -p %{build_data}/ex > mkdir -p %{build_docs}/html > mkdir -p %{build_docs}/graphics > ... > install -p -m 0644 input/* %{build_data}/input > install -p -m 0644 format/* %{build_data}/format > install -p -m 0644 lib/* %{build_data}/lib > install -p -m 0644 ex/* %{build_data}/ex > install -p -m 0644 docs/html/*.* %{build_docs}/html > install -p -m 0644 docs/graphics/* %{build_docs}/graphics Could you use "cp -a" here instead? Or, since the Source is a fork you control, consider adding an "install" target to the Makefile and just doing %make_install. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2040118 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
