[Bug 2009450] Review Request: python-kanboard - Python API Client for Kanboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2009450



--- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Let me point out a more serious problem with the package:


https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_running_tests

"""If a test suite exists upstream, it SHOULD be run in the %check section. If
that is not possible with reasonable effort, at least a basic smoke test (such
as importing the packaged module) MUST be run in %check."""


The test suite is
https://github.com/kanboard/python-api-client/blob/master/test_kanboard.py and
if that is not possible to run with reasonable effort, at least add
%pyproject_check_import to %check.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2009450
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux