Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: BlockOutII - A free adaptation of the original BlockOut DOS game Alias: BlockOutII https://bugzilla.redhat.com/show_bug.cgi?id=398791 chris.stone@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From chris.stone@xxxxxxxxx 2007-11-30 12:51 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output BlockOutII.x86_64: E: invalid-desktopfile /usr/share/applications/fedora-BlockOutII.desktop see comment #8 - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - package licensed with fedora approved license - license matches actual license - license file in %doc - written in American english - spec file legible - sources match upstream: $ diff -ur BlockOutII-2.3/ ../SOURCES/BlockOutII-2.3 Only in BlockOutII-2.3/BlockOut/sounds: music.mp3 Only in ../SOURCES/BlockOutII-2.3/BlockOut/sounds: music.ogg - successfully compiles and builds on F-7 x86_64 - All dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates - all other directories brought in from requires - no duplicates in %files - contains proper %clean - macro usage is consistent - contains code - no large documentation - no header files - no static libraries - no pkgconfig files - package contains proper desktop file see comment #7 - package does not own files or directories owned by other packages - buildroot removed at beginning of %install - all filenames valid UTF-8 ==== SHOULD FIX ==== - investigate why 1024x768 does not display properly in full screen (are you able to reproduce) - file bug mention in comment #7 **** APPROVED **** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review