Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kuftp - Graphical FTP Client for KDE https://bugzilla.redhat.com/show_bug.cgi?id=386531 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2007-11-30 12:46 EST ------- (In reply to comment #13) > Update to version 0.9.1 and added install and thanks file to %doc Remove the INSTALL file please. It only holds generic information about building this package from source, so it's not needed in the RPM. Some more issues I found: License should be GPLv2+. COPYING says it's GPLv2, but if you take a look at the files source code you will find the following: * This program is free software; you can redistribute it and/or modify * * it under the terms of the GNU General Public License as published by * * the Free Software Foundation; either version 2 of the License, or * * (at your option) any later version. "any later version" means GPLv2+, GPLv2 would be "GPL version 2 only". Group: /Applications/Internet should be Group: Applications/Internet (without the leading slash) The description line is WAY TO LONG, please insert line breaks after 79 characters, so the description will fit on a standard 80x25 terminal. There are also some errors in the description: most notable features ARE ... (Plural). missing whitespace between "is,you". The whole second sentence sounds a like bad English to me, but that should better be decided by a native speaker. >From your spec: make DESTDIR=$RPM_BUILD_ROOT install rm -f %{buildroot}%{_libdir}/libkuftpbookmarks.a Please don't mix different macro styles: Ether use %{buildroot} OR $RPM_BUILD_ROOT but not both, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf Remove the "--add-category=Network" statement from desktop-file-install, because the group Network already is in the desktop file. $ rpmlint Downloads/kuftp-0.9.1-1.fc8.src.rpm kuftp.src:63: W: macro-in-%changelog doc kuftp.src:81: W: macro-in-%changelog doc You need to escape macros in the changelog with a second %, so %doc becomes %%doc. kuftp.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24) Please only use spaces OR tabs, but not both. kuftp.src: E: description-line-too-long KuFtp is a graphical FTP client for the K Desktop Environment. Most notable features is Tab Sessions like Konqueror or Firefox, that is,you can have multiple simultaneous FTP session in separate tabs. see above kuftp.src: W: non-standard-group /Applications/Internet see above kuftp.src: W: strange-permission kuftp.spec 0755 the permissions of the spec in the SRPM should be 664 or 644, but the file should no be executable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review