Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-setools - SETools Eclipse Plugin https://bugzilla.redhat.com/show_bug.cgi?id=390571 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-11-30 08:11 EST ------- Well, for 3.3.2-1: * License > License is stated at public website > http://oss.tresys.com/projects/setools/wiki/license - In this case, please use LGPLv2+. (However, would you ask upstream developer to include license text in the tarball from next version?) * SourceURL - Now as it seems you are using formally released tarball, please write a full URL for Source0. * rpmlint: E: empty-debuginfo-package - For this package, the files under arch-specific directories (i.e. %_libdir) are either text files or symlinks, so debuginfo is useless for this package. So please refer to the section "Useless or incomplete debuginfo packages due to other reasons" of http://fedoraproject.org/wiki/Packaging/Debuginfo and write in the spec file like: ------------------------------------------------------- Requires: setools-libs-java >= %{require_setools_major_ver}%{require_setools_fix_ver} Requires: eclipse-platform Requires: java-gcj-compat >= 1.0.33 BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) # Files under %%_libdir are either text files or symlinks to the libraries # in setools-libs-java, so debuginfo rpm is useless. %define debug_package %{nil} %description -------------------------------------------------------- Note: in the comment or %changelog, please use %% so that macros won't be expanded. (In reply to comment #11) > I fixed the symlinks, but there is still some complaint about the .so files. - Can be ignored for this package. > I was also messing with ppc support. While I can't test it, it might now build. - Actually this builds on all archs. http://koji.fedoraproject.org/koji/taskinfo?taskID=267040 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review