Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trousers - The open-source TCG software stack https://bugzilla.redhat.com/show_bug.cgi?id=323441 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-11-30 07:18 EST ------- Well, I just tried to rebuild 3.3.1-2, however it again failed. http://koji.fedoraproject.org/koji/taskinfo?taskID=267051 You have to patch against Makefile.in. Patching against Makefile.am does not change anything (unless you call automake or so, however please avoid to use autotools when possible). * By the way: - Not a big problem, however your comments ---------------------------------------------------------- %build %configure make %{?_smp_mflags} # <- FROM THIS LINE # $1 is the number of entries in the RPM database for the package after the step is # executed. So in the post step, if $1 is 1, then this is the first time we've been # installed. If its 2, we're upgrading. # <- TO THIS LINE %post /sbin/ldconfig ------------------------------------------------------------- is in %build section. - And I usually write in the order of %prep, %build, %install, %clean, %pre, %post, %preun, and %postun (I am only saying my habit). By the way, where is %clean section? - calling ldconfig for -devel package is not needed. - I recomment to use http://trousers.sourceforge.net/ for URL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review