https://bugzilla.redhat.com/show_bug.cgi?id=2037645 --- Comment #10 from José Matos <jamatos@xxxxxxxx> --- In addition to Christopher's remark here are some other issues. You should bump the release number after each change in the review process. It becomes easier for us to see the progress between versions. The srpm does not build, the root cause is that the binaries are installed in /usr/local/bin and not in /usr/bin as you declare in %files: ... running install_scripts Installing ck2cti script to /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/local/bin Installing ck2yaml script to /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/local/bin Installing cti2yaml script to /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/local/bin Installing ctml2yaml script to /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/local/bin Installing ctml_writer script to /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/local/bin ... Processing files: cantera-common-2.6.0-0.3.a4.fc36.x86_64 error: File not found: /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/bin/ck2cti error: File not found: /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/bin/ck2yaml error: File not found: /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/bin/cti2yaml error: File not found: /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/bin/ctml2yaml error: File not found: /builddir/build/BUILDROOT/cantera-2.6.0-0.3.a4.fc36.x86_64/usr/bin/ctml_writer Regarding the spec some other suggestions. Where you have: %if 0%{?fedora} BuildRequires: gcc-fortran %endif %if 0%{?rhel} BuildRequires: gcc-gfortran %endif I would suggest: %if 0%{?fedora} BuildRequires: gcc-fortran %else BuildRequires: gcc-gfortran %endif The initial code is correct, of course, but the advantage of my suggestion is that it shows the intent. We see immediately that the purpose is to satisfy the same requirement on different systems. Another suggestion, that is completely optional, is to avoid to repeat the description text: %global common_description %{expand: \ Cantera is a suite of object-oriented software tools for solving problems involving chemical kinetics, thermodynamics, and/or transport processes. Cantera can be used for simulating time-dependent or steady reactor networks and one-dimensional reacting flows. Thermodynamic models for ideal gases, aqueous electrolytes, plasmas, and multiphase substances are provided.} And then you can simply replace them in the different descriptions: %description %{common_description} %package common Summary: Common files needed for all Cantera interfaces %description common %{common_description} This package includes programs for parsing and converting chemical mechanisms, a set of common mechanism files, and several sample problems. ... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2037645 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
