https://bugzilla.redhat.com/show_bug.cgi?id=2037645 --- Comment #9 from Christopher Crouse <mail@xxxxxxxxx> --- Looks much better now! Some more comments: - I noticed the changelog is in a nonstandard format. I would recommend using "rpmdev-bumpspec", will handle adding the entry and formatting the entry correctly for you. See what the output is of the following command on your spec file: $ rpmdev-bumpspec --comment="Foo" Note: Might also might want to look into rpmautospec, only once imported. It will make maintaining and writing the *Release* and *%changelog* messages unnecessary in the future. Documentation here: https://docs.pagure.org/fedora-infra.rpmautospec/index.html - I see that you have enabled fedora-review on your COPR repo. These files can help you debug issues when packaging: - https://download.copr.fedorainfracloud.org/results/fuller/Cantera/fedora-35-x86_64/03130228-cantera/fedora-review/review.txt - https://download.copr.fedorainfracloud.org/results/fuller/Cantera/fedora-35-x86_64/03130228-cantera/fedora-review/licensecheck.txt - https://download.copr.fedorainfracloud.org/results/fuller/Cantera/fedora-35-x86_64/03130228-cantera/fedora-review/rpmlint.txt - I always put some newlines between the macros I use in the %files section. It improves the readability and also a personal preference, for example: ... %doc %{_mandir}/man1/ctml_writer.1.gz %{_bindir}/ck2cti %{_bindir}/ck2yaml %{_bindir}/cti2yaml %{_bindir}/ctml2yaml %{_bindir}/ctml_writer %{_datadir}/%{name} ... - Lastly, would recommend to do a koji scratch build yourself, and adding the URL in the comments. Documentation here: https://docs.fedoraproject.org/en-US/package-maintainers/Using_the_Koji_Build_System/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2037645 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
