https://bugzilla.redhat.com/show_bug.cgi?id=2033890 --- Comment #5 from Arthur Bols <arthur@xxxxxxxx> --- > Is this really a problem? > I usually translate meson dev library requirements into BuildRequires 1:1 so I don't miss any constraints from upstream, so I'd like to keep them there. It's recommended (SHOULD) in the packaging guidelines [0], but since you have a decent justification, it's fine for me. > This *is* weird. I have asked upstream why they install icons for double pixel density if they are just duplicates, and that the hicolor icon theme apparently does not supprt @2 at all: > https://github.com/elementary/tasks/issues/321 I searched a bit further and it seems it's used for hi-resolution displays, but the way it's used here is wrong (I think). hicolor-icon-theme apparently does support @2, it's a bit vague in the spec [1] and I don't understand why they "fixed" it in 0.16 by adding it to the index.theme file but didn't change the build to create the directories... There also seems to be an oversight by adding arbitrary scaling support in the spec, but only supporting @2 and not @3... GammaRay seems to do it correctly [2] and [3], but the directories are still not owned by anything. They use @2 and @3, but since hicolor-icon-theme only supports @2, I'm not sure if @3 would even do anything but wasting space. Also, this issue is actually present for many elementary packages, but first let's see how this problem is solved upstream. If you'd like the package to approved, I think it's fine to remove the @2 directories (since they are just the same icons and thus shouldn't do anything) and add a comment linking to the upstream issue. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies [1] https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html [2] https://github.com/KDAB/GammaRay/tree/master/ui/resources/gammaray [3] https://src.fedoraproject.org/rpms/gammaray/blob/rawhide/f/gammaray.spec -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033890 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
