[Bug 2033890] Review Request: elementary-tasks - Synced tasks and reminders application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2033890



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> Issues:
> =======
> - Unnecessary versioned buildrequires
>   - meson >= 0.49
>     Last 3 Fedora versions all have meson 0.59.4 or newer, so this should be
> unversioned.
>   - pkgconfig(granite) >= 6.2.0
>     Last 3 Fedora versions all have granite 6.2.0, so this should be
> unversioned.
>   - pkgconfig(libhandy-1) >= 0.90.0
>     Last 3 Fedora versions all have libhandy 1.2.3 or newer, so this should
> be unversioned.

Is this really a problem?
I usually translate meson dev library requirements into BuildRequires 1:1 so I
don't miss any constraints from upstream, so I'd like to keep them there.

> -  Duplicated icons
>    The package duplicates all icons in /usr/share/icons/hicolor/*@2/
> directories.
>    Is this necessary, especially since they are svgs? Otherwise these should
> be symlinked to avoid wasting storage space.

This *is* weird. I have asked upstream why they install icons for double pixel
density if they are just duplicates, and that the hicolor icon theme apparently
does not supprt @2 at all:
https://github.com/elementary/tasks/issues/321


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2033890
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux