https://bugzilla.redhat.com/show_bug.cgi?id=2031721 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I didn’t read what you’re doing with find and sed carefully enough. You’re simply removing all shebangs from Python files, because the upstream package has useless shebangs in its package modules. This is the right thing to do, and %py3_shebang_fix would have been the wrong thing to do, because it just fixes the shebangs so they do not use /usr/bin/env. Even better is to fix it *and* report the useless shebangs upstream, as I have done here: https://github.com/jwouters91/shybrid/pull/13 Full re-review to follow… -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2031721 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
