https://bugzilla.redhat.com/show_bug.cgi?id=2033481 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #6 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Several comments, nothing really bad, just nit-picks: > %{?python_provide:%python_provide python3-%{pypi_name}} This is deprecated and should not be used. It more or less does nothing. > python3 pywaffle/scripts/get_fontawesome.py %{python3} should be used, so it is possible to build the spec file with a different Python version (unlikely to be needed, but at least consistent). > %global pypi_name pywaffle > %global pypi_version 0.6.3 > %global githubname PyWaffle I highly recommend not doing this. It makes the spec file harder to read and the benefit is minimal, it is not like I could take the spec file, copy it, change the values and use it without changes for another package. Using the literal values in the spec file makes it easier to understand. > %license LICENSE This is not needed, as the LICENSE file is listed and marked as %license in %{pyproject_files}: $ rpm -ql --licensefiles -p python3-pywaffle-0.6.3-1.20210728git0857bae.fc36.noarch.rpm /usr/lib/python3.10/site-packages/pywaffle-0.6.3.dist-info/LICENSE /usr/share/licenses/python3-pywaffle/LICENSE (On Fedora 34 or EPEL 9 the file is installed, but not marked as %license.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033481 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
