https://bugzilla.redhat.com/show_bug.cgi?id=2033757 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- No, you didn't understand me. The link in *this ticket* should point to a plain .spec file, not an HTML page on GitHub ... Some more comments: - You can use %{url} as shortcut for the URL in Source0, no need to spell it out twice - Use standardized GitHub source URLs, as documented here: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags In this case, that would be (without the weird HTML anchor hack): Source0: %{url}/archive/%{version}/%{srcname}-%{version}.tar.gz - Use a simplified URL for patch: Patch0: %{url}/pull/151.patch - The %config / %config(noreplace) lines in %iles look weird. You're listing the same file twice, but with different (noreplace) settings, and without using macros. Just use %config(noreplace) %{_sysconfdir}/xdg/autostart/%{appname}.desktop Also add validation of this file to %check, like for the other desktop file. - The order of the files in %files is a bit odd, I usually make them follow alphabetical order as they are on the filesystem, and add those that use macros or flags on top, i.e. %files %license COPYING %doc README.md %config(noreplace) %{_sysconfdir}/xdg/autostart/%{appname}.desktop %{_bindir}/%{appname} %{_datadir}/applications/%{appname}.desktop %{_datadir}/metainfo/%{appname}.appdata.xml %{_datadir}/glib-2.0/schemas/%{appname}.gschema.xml %{_datadir}/icons/hicolor/*/apps/%{appname}.svg - Changelog is in a weird nonstandard format, use the normal one instead: - no leading empty line in %changelog - do not put the "- version-release" string onto a separate line, it belongs at the end of the first line You should take a look at what this command does to see the standard format: $ rpmdev-bumpspec --comment="Foo" Manually editing the %changelog is very error-prone, and I'd recommend never doing that. Instead, just let "rpmdev-bumpspec" handle the job, it generates a correctly formatted entry for you. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033757 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
