https://bugzilla.redhat.com/show_bug.cgi?id=2033481 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx CC| |zbyszek@xxxxxxxxx Status|NEW |POST --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- There is no need to stuff the snapshot information into the release tag. Do something like this instead: --- python-pywaffle.spec +++ python-pywaffle.spec @@ -2 +1,0 @@ -%global pypi_version 0.6.3 @@ -4,0 +4 @@ +%global commitdate 20210728 @@ -9,2 +9,2 @@ Name: python-%{pypi_name} -Version: %{pypi_version} -Release: %{autorelease -s 20210728git%{shortcommit}} +Version: 0.6.3^%{commitdate}git%{shortcommit} +Release: %autorelease + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + BR/R/P look OK + fedora-review finds no issues (except some false positives) + rpmlint: python3-pywaffle.noarch: W: spelling-error %description -l en_US matplotlib -> diplomatist python3-pywaffle.noarch: W: spelling-error %description -l en_US pyplot -> plot python3-pywaffle.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/pywaffle/__init__.py 644 /usr/bin/python python3-pywaffle.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/pywaffle/fontawesome/__init__.py 644 /usr/bin/python python3-pywaffle.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/pywaffle/waffle.py 644 /usr/bin/python 1 packages and 0 specfiles checked; 3 errors, 2 warnings. Those can all be ignored. I'm not keen on all those macros. It's a matter of preference, but let me just say that github repo naming is case-insensitive, so you could just use "pywaffle" everywhere and everything should work… Package is APPROVED. Please consider using the more modern version-release split as suggested above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2033481 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
