https://bugzilla.redhat.com/show_bug.cgi?id=2028188 --- Comment #1 from Olivier Lemasle <o.lemasle@xxxxxxxxx> --- - Package ocaml-mtime-devel includes both /usr/lib64/ocaml/mtime/mtime.ml and /usr/lib64/ocaml/mtime/mtime.mli, whereas the Fedora OCaml Packaging Guidelines state that for the -devel subpackage: > .ml files are not normally included. The exception is if the file describes a module > signature and there is no corresponding .mli file, then the .ml file should be > included. (Note that Debian is more permissive and they often distribute *.ml files, > allowing the programmer to peek at the implementation of a module). Not being an OCaml developer, could you please tell me if there's a good reason to include the .ml file here? - The tests are not executed, but only because they depend on non-packaged dependency. Otherwise: - Latest version is packaged (1.3.0) - License ISC OK - Package name OK - Package builds in mock - The spec, including changelog, conforms to the Packaging Guidelines and the OCaml Packaging Guidelines Rpmlint results: ocaml-mtime-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/ocaml-mtime-1.3.0-1.fc36.x86_64 ocaml-mtime-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/ocaml/mtime/mtime.cmxs-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/ocaml/mtime/mtime_top.cmxs-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/ocaml/mtime/os/mtime_clock.cmxs-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/ocaml/stublibs/dllmtime_clock_stubs.so-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/ocaml-mtime-1.3.0-1.fc36.x86_64 ocaml-mtime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/mtime/mtime.a ocaml-mtime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/mtime/mtime_top.a ocaml-mtime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/mtime/os/libmtime_clock_stubs.a ocaml-mtime-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/mtime/os/mtime_clock.a ocaml-mtime.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/mtime/mtime.cmxs ocaml-mtime.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/mtime/mtime_top.cmxs ocaml-mtime-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/ocaml/mtime/mtime.cmxs-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/ocaml/mtime/mtime_top.cmxs-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/ocaml/mtime/os/mtime_clock.cmxs-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/ocaml/stublibs/dllmtime_clock_stubs.so-1.3.0-1.fc36.x86_64.debug ocaml-mtime-debuginfo.x86_64: W: no-documentation ocaml-mtime-debugsource.x86_64: W: no-documentation ocaml-mtime-devel.x86_64: W: no-documentation ocaml-mtime-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/ocaml-mtime-1.3.0-1.fc36.x86_64 ocaml-mtime-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz ocaml-mtime-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz ocaml-mtime-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/8f/5e93351c169bac26642209d7f84aa368fb1e74 ../../../.build-id/8f/5e93351c169bac26642209d7f84aa368fb1e74 ocaml-mtime-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/cb/b576aa886fcb61d053f8be68bd22734bd0b8b4 ../../../.build-id/cb/b576aa886fcb61d053f8be68bd22734bd0b8b4 ocaml-mtime-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/df/3cce89fc1a859dcd0c2c2fa21c5e2dc1b872ba ../../../.build-id/df/3cce89fc1a859dcd0c2c2fa21c5e2dc1b872ba ocaml-mtime-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/e9/e21ef5c86e3fed27a26ee75b248b90f504ec5e ../../../.build-id/e9/e21ef5c86e3fed27a26ee75b248b90f504ec5e -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2028188 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
