https://bugzilla.redhat.com/show_bug.cgi?id=2023085 --- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Thanks for reviewing Zbigniew! > - package name is OK > I think the name is OK, but I expect users will want to say 'dnf install xq'. So please add Provides:xq. I did it wrong. Package should be named xq.spec directly, as with other go packages and as the name of the BZ shows. > install -m 0755 -vd %{buildroot}%{_bindir} > install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ > → > install -Dpvt %{buildroot}%{_bindir}/ %{gobuilddir}/bin/* This comes from go2rpm, maybe the change needs to go to that package so everyone applies the same. I updated the spec with correct name: Spec URL: https://mikel.olasagasti.info/tmp/fedora/xq.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/xq-0.0.6-1.fc35.src.rpm I don't think the name changing changes the review, so I'm requesting the repo. If you think I should create a nwe BZ or alike let me know. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2023085 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
