https://bugzilla.redhat.com/show_bug.cgi?id=2023085 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx CC| |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- - package name is OK I think the name is OK, but I expect users will want to say 'dnf install xq'. So please add Provides:xq. - license is acceptable for Fedora (MIT) - license is specified correctly - latest version: Please update to 0.0.6 (released 20h ago ;)) - builds and installs OK - seems to work as expected - the standard go template is used - BR/P/R look OK (apart from the note above…) Suggestion: install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ → install -Dpvt %{buildroot}%{_bindir}/ %{gobuilddir}/bin/* rpmlint: golang-github-sibprogrammer-xq.src: W: spelling-error Summary(en_US) jq -> j, q, sq golang-github-sibprogrammer-xq.src: W: spelling-error %description -l en_US jq -> j, q, sq golang-github-sibprogrammer-xq.src:56: W: macro-in-%changelog %autochangelog golang-github-sibprogrammer-xq.x86_64: W: spelling-error Summary(en_US) jq -> j, q, sq golang-github-sibprogrammer-xq.x86_64: W: spelling-error %description -l en_US jq -> j, q, sq golang-github-sibprogrammer-xq.x86_64: W: no-manual-page-for-binary xq golang-github-sibprogrammer-xq-devel.noarch: W: spelling-error Summary(en_US) jq -> j, q, sq golang-github-sibprogrammer-xq-devel.noarch: W: spelling-error %description -l en_US jq -> j, q, sq golang-github-sibprogrammer-xq-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/sibprogrammer/xq/.goipath 5 packages and 0 specfiles checked; 0 errors, 9 warnings. All bogus. Package is APPROVED. Please see some notes above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2023085 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
