[Bug 2021429] Review Request: python-pyedflib - pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2021429

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(code@musicinmybra |
                   |in.net)                     |



--- Comment #10 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
It turns out that:

- pyedflib actually uses a slightly forked version of EDFlib
- EDFlib upstream has decided not to support big-endian architectures

I will keep the separate edflib package working on s390x, I think, but porting
an edflib patch to the forked version here and testing it adequately seems
tedious and perhaps error-prone. I think your best approach may be:

> # Uses a forked copy of EDFlib (https://gitlab.com/Teuniz/EDFlib), which has
> # elected not to support big-endian architectures.
> ExcludeArch:    s390x
>
> # Uses a forked copy of EDFlib (https://gitlab.com/Teuniz/EDFlib)
> # https://github.com/holgern/pyedflib/issues/149
> # Version number: pyedflib/_extensions/c/edflib.c, EDFLIB_VERSION
> Provides:       bundled(edflib) = 1.17

Then after import, per
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures,
file an RHBZ issue blocking F-ExcludeArch-s390x with the explanation from the
comment above the ExcludeArch, and replace or augment that spec file comment
with a link to the issue.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2021429
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux