https://bugzilla.redhat.com/show_bug.cgi?id=2021429 --- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Ok, I’ve sent a PR upstream to support a system copy of EDFlib: https://github.com/holgern/pyedflib/pull/150 One way to reference it is: > Patch1: %{url}/pull/150.patch Also, upstream has released a new version, 0.1.23. That’s almost enough to prepare an updated submission with the new upstream version and the patch. You will need to add a BR on edflib-devel, “export SYSTEM_EDFLIB=1” before calling %pyproject_wheel, and “rm -rf pyedflib/_extensions/c” in %prep to verify the bundled library is not used. However, I think another patch will be needed for compatibility with the latest version of edflib: > pyedflib/_extensions/_pyedflib.c: In function ‘__pyx_pf_8pyedflib_11_extensions_9_pyedflib_11CyEdfReader_8open’: > pyedflib/_extensions/_pyedflib.c:5196:20: error: too many arguments to function ‘edfopen_file_readonly’ > 5196 | __pyx_v_result = edfopen_file_readonly(__pyx_t_3, (&__pyx_v_self->hdr), __pyx_t_4, __pyx_t_5); > | ^~~~~~~~~~~~~~~~~~~~~ > In file included from pyedflib/_extensions/_pyedflib.c:657: > /usr/include/edflib.h:204:5: note: declared here > 204 | int edfopen_file_readonly(const char *path, struct edf_hdr_struct *edfhdr, int read_annotations); > | ^~~~~~~~~~~~~~~~~~~~~ I’ll take a look at that next. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2021429 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
