https://bugzilla.redhat.com/show_bug.cgi?id=2022991 --- Comment #5 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > The reason for making a separate systemd subpackage is to make it optional. Not everybody wants to run i2pd as a system service, some people may prefer to run it as a regular program. It's completely useless without systemd modules. Fedora uses systemd as its unified init system. That's why I think, these units should be moved to the base package. > I'd like to have a single spec file for both CentOS 7 and Fedora and avoid conditional statements as much as possible. %cmake3 macro is obsolete and should not be used. Use %cmake for Fedora and %cmake3 for RHEL7. Also EPEL7 will use its own git branch epel7. You can make such changes in it. > Done using CMAKE_SKIP_RPATH variable instead. There is no %cmake_install in %install section, all files are installed manually, no internal shared libraries used, so no need to build i2pd with rpath pointing to builddir. RPATH is strictly forbidden on Fedora. If it exists, it must be removed. > This is needed for migration from older version of this package. Some of users may have older version installed from my OBS repo, and it would be a very unpleasant surprise for them if their configuration was not migrated to the new place automatically. Is there a better, more recommended way to migrate configuration files to a new (more standards conforming) location? Such scriptlets are not allowed, because they are touching different files and directories not owned by your package. If you want to publish your package to Fedora, it must follow current Fedora packaging guidelines. In general such scriplets must be guarded with %triggerrun: %triggerun -- %{name} < 1.0.0-2 ... do some hacks ... It will only be executed by RPM if the installed version meets the condition. > There is a changelog, it's just stored in a separate file in OBS Fedora doesn't allow detached changelogs (only auto-generated from Git history). > Changelog URL: https://obs.infoserver.lv/package/view_file/i2p/i2pd/i2pd.changes?expand=1 Incorrect. You must move contents of this file to %changelog section of the base SPEC. > It can't. The "build" directory is a special part of i2pd source, not a normal builddir: "CMakeLists.txt" file and cmake modules are located there. The builddir is created inside "build" directory for out of source build. Just use %cmake -S build. > This will break build for older Fedora versions (<31) that have no %cmake_build macro. We don't have to worry about the EOLed versions of Fedora. Currently supported are F34, F35 and Rawhide. You should do this. > Also please ignore that I didn't increase release number, OBS does this automatically, as you can see from SRPM file name and its version. Fedora uses Koji, not OBS. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2022991 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
