[Bug 2021429] Review Request: python-pyedflib - pyedflib is a python library to read/write EDF+/BDF+ files based on EDFlib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2021429



--- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
(In reply to Iztok Fister Jr. from comment #4)
> I have already committed a revision. Please take a look:
> https://github.com/firefly-cpp/rpm-pyedflib/commit/
> 9aac7aec444f3a7f150b5b60986f7166da79895e
> 
> However, build on s390 is failing due to the tests:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=78702562
> 
> Shall we disable specific test?

Maybe. Or, the problem might be serious enough that the architecture should be
excluded (which is still possible in a noarch package).

I haven’t looked closely at the problem yet. I suspect this is a byte order
issue, since s390x is the only big-endian architecture in Fedora.

The best answer would be to fix the actual problem and send a patch upstream.
I’ll attempt that, but it might take me a few days to get around to it.

> I prefer that you approve a SPEC file without documentation and later submit
> a PR to the rpms repo. What do you think?

Works for me!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2021429
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux