[Bug 1979790] Review Request: golang-github-schollz-cli-2 - A simple, fast, and fun package for building command line apps in Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1979790

Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(hiwkby@xxxxxxxxx)
                 CC|                            |michel@xxxxxxxxxxxxxxx



--- Comment #11 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
Hi Hirotaka,

(In reply to Hirotaka Wakabayashi from comment #10)
> Hello Davide, thank you for your comment!
> 
> It is reasonable for me to submit patches to the Fedora repository. I wonder
> how everybody can track changes of them.
> 
I think there's some confusion here. As Davide said, this patch *will* be
checked in once the review is approved and there is a dist-git repo for the
package. Otherwise, we don't really have a place to check it in anyway.

> Could you ask schollz to merge the patch? I think you need not to add the
> patch to the Fedora repository if the patch is accepted by the upstream.
> 
It's unrealistic to expect a package to have no patches at review time, I
think. Even once it's approved, patches will be needed occasionally. The
requirement that patches have links is exactly so we can keep the number we
carry to a minimum, as we can check if they have been merged (or, by using
'spectool -gf', to notice if they have been updated, if it's a patch by a third
party)

> If you think you need no changes anymore, I can ask the Fedora Packaging
> Committee how to apply the patch guidelines in this case.
> 
I don't think FPC needs to weigh in here, it will just block the review
unnecessarily. But thanks for being really thorough!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1979790
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux