[Bug 1979790] Review Request: golang-github-schollz-cli-2 - A simple, fast, and fun package for building command line apps in Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1979790



--- Comment #8 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> ---
Hello Davide, 

Thank you for your reply. I confirmed the rpmlint error is fixed.
I found another thing. Patch files must be checked into the Fedora 
package repository. Please change the spec file like this:
```
# Make test case compatible with Go 1.17
# https://github.com/urfave/cli/pull/1299
Patch0: app_test.go.patch
```
Please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_applying_patches

Thanks in advance,
Hirotaka


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1979790
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux