https://bugzilla.redhat.com/show_bug.cgi?id=1986844 Robby Callicotte <rcallicotte@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcallicotte@xxxxxxxxxxxxxx --- Comment #6 from Robby Callicotte <rcallicotte@xxxxxxxxxxxxxx> --- Greetings, This is an unofficial review... I am not a packager. "rpmlint -i ircii" states the following: ircii.spec:17: W: setup-not-quiet Use the -q option to the %setup macro to avoid useless build output from unpacking the sources. ircii.spec:20: W: rpm-buildroot-usage %build %configure --mandir=%{buildroot}/%{_mandir} $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may break short circuit builds. ircii.spec: W: no-%install-section The spec file does not contain an %install section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality. Add the section, even if empty. As Gustavo stated previously, the macro form (%{_mandir}, %{_bindir}, etc) should be used in the %files section. Stylistically, I believe that the "Name" tag in the spec should be listed before anything else in the preamble except for use of %global definitions. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1986844 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
