https://bugzilla.redhat.com/show_bug.cgi?id=2014324 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > URL: https://github.com/resurrecting-open-source-projects/%{name} > Source0: https://github.com/resurrecting-open-source-projects/%{name}/archive/%{version}/%{name}-%{version}.tar.gz You can use %{URL} as part of Source0 for brevity. > BuildRequires: libbsd-devel > BuildRequires: imlib2-devel > BuildRequires: libX11-devel > BuildRequires: libXext-devel > BuildRequires: libXcomposite-devel You can use pkgconfig to specify dependencies. This way, if a package gets renamed / split / merged, you won't be affected. i.e. "BuildRequires: pkgconfig(imlib2) pkgconfig(libbsd) pkgconfig(x11) pkgconfig(xext) pkgconfig(xcomposite)" > make %{?_smp_mflags} Try using "%make_build" instead. > %files > %doc AUTHORS ChangeLog README.md scrot.png You need to add "%license COPYING" here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2014324 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
