https://bugzilla.redhat.com/show_bug.cgi?id=2013336 --- Comment #5 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/praiskup/resalloc-aws/main/resalloc-aws.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/praiskup/resalloc-aws-ci/srpm-builds/02890437/resalloc-aws-1.1-1.fc35.src.rpm > A few minor grammar errors in the description Fixed. > In the %install section there is a couple of macros used as %foo while the rest of the spec uses %{foo}. Fixed. > Please use %{buildroot}%{_bindir} or / as a separator. Fixed, but technically, %buildroot%_bindir is just OK (my preferred variant). > This would maybe fit better a %setup phase instead of a %install phase? Indeed. I moved it to %build which is even better, which fixes the rpmlint no-%build-section complaint. > Also, maybe it would be better to use %{__python3} instead of /usr/bin/python3 Fixed. > I am not sure if `bash` should be specified as a runtime dependency or if it can be omitted. > Do you know? > wait-for-ssh is a python script, so I think python should be specified as a runtime dependency as well. There's an automatic "Requires: /usr/bin/bash" and "Requires: /usr/bin/python3". Thank you for the review, Jakube! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2013336 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
