https://bugzilla.redhat.com/show_bug.cgi?id=2010688 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > FIX: Please switch source from search.cpan.org to metacpan.org -Source: http://search.cpan.org/CPAN/authors/id/F/FA/FANGLY/Math-Random-MT-%{version}.tar.gz +Source: https://cpan.metacpan.org/authors/id/F/FA/FANGLY/Math-Random-MT-%{version}.tar.gz Ok > FIX: Please add following build-requires: > perl(Carp) - MT.pm:4 > perl(DynaLoader) - MT.pm:5 > perl(strict) - MT.pm:3 > perl(vars) - MT.pm:6 > perl(Benchmark) - t/9.t:3 -BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(Benchmark) +BuildRequires: perl(Carp) +BuildRequires: perl(DynaLoader) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(Test::More) BuildRequires: perl(Test::Number::Delta) +BuildRequires: perl(strict) +BuildRequires: perl(vars) > FIX: Please remove obsolete Group tag -Group: Development/Libraries Ok. > FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to > 6.76 or higher, because NO_PACKLIST option was added in this version. +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Ok > TODO: Remove the deleting empty directories in %install section. This is > default behavior for Fedoras. > TODO: Removing *.bs file could be simplyfied > find %{buildroot} -type f -name '*.bs' -empty -delete -find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';' -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' - +find %{buildroot} -type f -name '*.bs' -empty -delete Ok. Ok. The package is in line with Fedora and Perl packaging guide lines now. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2010688 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
