[Bug 2008090] Review Request: libzdnn - IBM Z specific hardware exploitation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2008090



--- Comment #8 from Dan Horák <dan@xxxxxxxx> ---
Thanks, the 0.3.1-2 looks good to me. One minor nitpick - please add a new line
between the %changelog entries.

Regarding the -march flags, I think that one option could be removing the
distro values from %optflags and then relying on the upstream mechanism to set
the -march=z14. Something like

%global optflags $(echo %optflags | sed -e 's/-march=z[[:alnum:]]\+//g' -e
's/-mtune=z[[:alnum:]]\+//g')

In the current revision you likely end up with -march=z14 -mtune=z13
combination, which might be suboptimal.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2008090
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux