[Bug 1977987] Review Request: anarch - minimalist first person shooter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1977987



--- Comment #23 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> ---
> typo on line 26: the description macro should be desc_text (currently is desc_test)
Thanks, fixed.

> You need to require hicolor-icon-theme which owns the icon directories.
Oh, oops. Fixed.

> Compilation warning worth looking at:
> main_sdl.c: In function 'SFG_sleepMs':
> main_sdl.c:172:3: warning: implicit declaration of function 'usleep'; did you mean 'sleep'? [-Wimplicit-function-declaration]
Fixed via compiler flags.

> anarch-CSFML.x86_64: E: summary-too-long
> anarch-SDL2.x86_64: E: summary-too-long
Shortened the summary and fixed the redefinition issue.

> You can use the forge macros to simplify the spec if you wish:
> You can use the %autosetup macro, it does the patching for you too: 
Maybe one day. Can't teach an old dog new tricks. ;)

Updated links:
spec: https://svgames.pl/fedora/anarch-1.02d-3.20210616gitf6a6a68a/anarch.spec
srpm:
https://svgames.pl/fedora/anarch-1.02d-3.20210616gitf6a6a68a/anarch-1.02d-3.20210616gitf6a6a68a.fc34.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=76516558


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1977987
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux