https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #22 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks very good. Just a few minor things to fix up: - You can use the forge macros to simplify the spec if you wish: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control - typo on line 26: the description macro should be desc_text (currently is desc_test) - You can use the %autosetup macro, it does the patching for you too: https://rpm-software-management.github.io/rpm/manual/autosetup.html - You need to require hicolor-icon-theme which owns the icon directories. See the filesystem bit here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function - Compilation warning worth looking at: main_sdl.c: In function 'SFG_sleepMs': main_sdl.c:172:3: warning: implicit declaration of function 'usleep'; did you mean 'sleep'? [-Wimplicit-function-declaration] 172 | usleep(timeMs * 1000); | ^~~~~~ | sleep - You can use autochangelog if you wish: https://fedoraproject.org/wiki/Changes/rpmautospec RPMlint bits: - anarch-CSFML.x86_64: E: summary-too-long Suckless, anarcho-pacifist, 90s-style Doom clone that runs everywhere (SDL2 version) (CSFML version) ^ "SDL2 version" shouldn't be here I seems like %summary is being redefined for each sub-package. I'm not sure if this is supposed to happen, though. - anarch-SDL2.x86_64: E: summary-too-long Suckless, anarcho-pacifist, 90s-style Doom clone that runs everywhere (SDL2 version) ^ Could perhaps shorten this a bit to make rpmlint happy? - because of typo in desc_text: anarch.src: W: unexpanded-macro %description -l C %{desc_text} anarch-CSFML.x86_64: W: unexpanded-macro %description -l C %{desc_text} anarch-SDL2.x86_64: W: unexpanded-macro %description -l C %{desc_text} ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Creative Commons CC0 1.0", "Creative Commons CC0 1.0". 206 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora- reviews/1977987-anarch/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/128x128/apps ^ I think you need to require hicolor-icon-theme which owns these directories: https://packages.fedoraproject.org/pkgs/hicolor-icon-theme/hicolor-icon-theme/ [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: anarch-SDL2 (description), anarch-CSFML (description) [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in anarch- SDL2 , anarch-CSFML [?]: Package functions as described. ^ Not tested this. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- ============================================================= rpmlint session starts ============================================================= rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 7 anarch-CSFML-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/anarch-csfml-1.02d-2.20210616gitf6a6a68a.fc36.x86_64.debug anarch-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/anarch-1.02d-2.20210616gitf6a6a68a.fc36.x86_64 anarch-SDL2-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/anarch-sdl2-1.02d-2.20210616gitf6a6a68a.fc36.x86_64.debug anarch.src: W: unexpanded-macro %description -l C %{desc_text} anarch-CSFML.x86_64: W: unexpanded-macro %description -l C %{desc_text} anarch-SDL2.x86_64: W: unexpanded-macro %description -l C %{desc_text} anarch-CSFML.x86_64: E: summary-too-long Suckless, anarcho-pacifist, 90s-style Doom clone that runs everywhere (SDL2 version) (CSFML version) ^ "SDL2 version" shouldn't be here I seems like %summary is being redefined for each sub-package. I'm not sure if this is supposed to happen, though. anarch-SDL2.x86_64: E: summary-too-long Suckless, anarcho-pacifist, 90s-style Doom clone that runs everywhere (SDL2 version) ^ Could perhaps shorten this a bit to make rpmlint happy? anarch-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/anarch-1.02d-2.20210616gitf6a6a68a.fc36.x86_64 anarch-CSFML-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/anarch-csfml-1.02d-2.20210616gitf6a6a68a.fc36.x86_64.debug anarch-SDL2-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/anarch-sdl2-1.02d-2.20210616gitf6a6a68a.fc36.x86_64.debug anarch-CSFML.x86_64: W: no-manual-page-for-binary anarch-csfml anarch-SDL2.x86_64: W: no-manual-page-for-binary anarch-sdl2 anarch-CSFML-debuginfo.x86_64: W: no-documentation anarch-debuginfo.x86_64: W: no-documentation anarch-debugsource.x86_64: W: no-documentation anarch-SDL2-debuginfo.x86_64: W: no-documentation anarch-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/anarch-1.02d-2.20210616gitf6a6a68a.fc36.x86_64 anarch-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz anarch-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz anarch.src: W: description-shorter-than-summary anarch-CSFML.x86_64: W: description-shorter-than-summary anarch-SDL2.x86_64: W: description-shorter-than-summary anarch-CSFML-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/a0/7c43f4607523c2ebaf16b7fbe6e4a37d1e34d4 ../../../.build-id/a0/7c43f4607523c2ebaf16b7fbe6e4a37d1e34d4 anarch-SDL2-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/f6/8b9e779fc3954082dcf1ee70a137aa5e221a81 ../../../.build-id/f6/8b9e779fc3954082dcf1ee70a137aa5e221a81 ============================= 7 packages and 0 specfiles checked; 6 errors, 19 warnings, 6 badness; has taken 8.3 s ============================== I don't know if anything should be done for the debug package related warnings/errors. Source checksums ---------------- https://gitlab.com/drummyfish/anarch/-/archive/f6a6a68a890716cd394c6fb2d00bd8123b51b18f/anarch-f6a6a68a890716cd394c6fb2d00bd8123b51b18f.tar.gz : CHECKSUM(SHA256) this package : 2e0b04ffc8b8bb79477d7df588ee1ef999f53e2749218653697a560785709175 CHECKSUM(SHA256) upstream package : 2e0b04ffc8b8bb79477d7df588ee1ef999f53e2749218653697a560785709175 Requires -------- anarch-SDL2 (rpmlib, GLIBC filtered): libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) anarch-CSFML (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcsfml-audio.so.2.5()(64bit) libcsfml-graphics.so.2.5()(64bit) libcsfml-system.so.2.5()(64bit) libcsfml-window.so.2.5()(64bit) rtld(GNU_HASH) anarch-debuginfo (rpmlib, GLIBC filtered): anarch-debugsource (rpmlib, GLIBC filtered): Provides -------- anarch-SDL2: anarch-SDL2 anarch-SDL2(x86-64) application() application(anarch-sdl2.desktop) metainfo() metainfo(anarch-sdl2.metainfo.xml) anarch-CSFML: anarch-CSFML anarch-CSFML(x86-64) application() application(anarch-csfml.desktop) metainfo() metainfo(anarch-csfml.metainfo.xml) anarch-debuginfo: anarch-debuginfo anarch-debuginfo(x86-64) anarch-debugsource: anarch-debugsource anarch-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1977987 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Python, Ocaml, Haskell, SugarActivity, Perl, Java, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1977987 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
