https://bugzilla.redhat.com/show_bug.cgi?id=2003876 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |pemensik@xxxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #5 from Petr Menšík <pemensik@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - Font is included inside package instead of reusing system font. - No %doc is used, but upstream contains some markdown files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "the Unlicense MIT License", "GNU General Public License v3.0 or later", "GNU General Public License v2.0 or later", "BSD (3 clause)", "Apache License 2.0". 378 files have unknown license. Detailed output of licensecheck in /home/reviewer/fedora/rawhide/2003876-sdrpp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Font package required [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines - ttf font file is included from upstream, not from distribution [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: sdrpp-1.0.3-1.fc36.x86_64.rpm sdrpp-debuginfo-1.0.3-1.fc36.x86_64.rpm sdrpp-debugsource-1.0.3-1.fc36.x86_64.rpm sdrpp-1.0.3-1.fc36.src.rpm sdrpp.x86_64: W: no-documentation sdrpp.x86_64: W: no-manual-page-for-binary sdrpp 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: sdrpp-debuginfo-1.0.3-1.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- sdrpp: /usr/lib64/sdrpp/plugins/audio_sink.so sdrpp: /usr/lib64/sdrpp/plugins/discord_integration.so sdrpp: /usr/lib64/sdrpp/plugins/file_source.so sdrpp: /usr/lib64/sdrpp/plugins/frequency_manager.so sdrpp: /usr/lib64/sdrpp/plugins/hackrf_source.so sdrpp: /usr/lib64/sdrpp/plugins/meteor_demodulator.so sdrpp: /usr/lib64/sdrpp/plugins/network_sink.so sdrpp: /usr/lib64/sdrpp/plugins/new_portaudio_sink.so sdrpp: /usr/lib64/sdrpp/plugins/radio.so sdrpp: /usr/lib64/sdrpp/plugins/recorder.so sdrpp: /usr/lib64/sdrpp/plugins/rigctl_server.so sdrpp: /usr/lib64/sdrpp/plugins/rtl_sdr_source.so sdrpp: /usr/lib64/sdrpp/plugins/rtl_tcp_source.so sdrpp: /usr/lib64/sdrpp/plugins/soapy_source.so sdrpp: /usr/lib64/sdrpp/plugins/weather_sat_decoder.so Source checksums ---------------- https://github.com/AlexandreRouma/SDRPlusPlus/archive/dcc17cdee75c55ab9d355d63b428db04c66b999b/sdrpp-dcc17cd.tar.gz : CHECKSUM(SHA256) this package : 9f27b959afe99ed4e29969327a9a0636cac66dd191cf41935a88ac9594b50b1b CHECKSUM(SHA256) upstream package : 9f27b959afe99ed4e29969327a9a0636cac66dd191cf41935a88ac9594b50b1b Requires -------- sdrpp (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libGLEW.so.2.1()(64bit) libOpenGL.so.0()(64bit) libSoapySDR.so.0.8()(64bit) libc.so.6()(64bit) libfftw3f.so.3()(64bit) libfmt.so.8()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglfw.so.3()(64bit) libhackrf.so.0()(64bit) libm.so.6()(64bit) libportaudio.so.2()(64bit) librtaudio.so.6()(64bit) librtlsdr.so.0()(64bit) libsdrpp_core.so.1.0.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvolk.so.2.5()(64bit) rtld(GNU_HASH) sdrpp-debuginfo (rpmlib, GLIBC filtered): sdrpp-debugsource (rpmlib, GLIBC filtered): Provides -------- sdrpp: application() application(sdrpp.desktop) bundled(imgui) bundled(nlohmann-json) bundled(stb_image) libsdrpp_core.so.1.0.3()(64bit) sdrpp sdrpp(x86-64) sdrpp-debuginfo: debuginfo(build-id) libsdrpp_core.so.1.0.3-1.0.3-1.fc36.x86_64.debug()(64bit) sdrpp-debuginfo sdrpp-debuginfo(x86-64) sdrpp-debugsource: sdrpp-debugsource sdrpp-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/reviewer/fedora/rawhide/2003876-sdrpp/srpm/sdrpp.spec 2021-09-18 19:12:12.814161015 +0200 +++ /home/reviewer/fedora/rawhide/2003876-sdrpp/srpm-unpacked/sdrpp.spec 2021-09-14 05:24:13.000000000 +0200 @@ -2,11 +2,9 @@ %global gittag 1.0.3 %global shortcommit %(c=%{commit}; echo ${c:0:7}) -# Upstream requests use of -O3 for DSP performance and specifies c++17 -%global optflags %(eval echo %{optflags} | %{__sed} -e 's/-O2/-O3 -std=c++17/') Name: sdrpp Version: 1.0.3 Release: 1%{?dist} -Summary: SDRPlusPlus bloat-free SDR receiver software +Summary: Bloat-free SDR receiver software License: GPLv3 @@ -32,22 +30,18 @@ BuildRequires: fftw-devel glew-devel volk-devel glfw-devel BuildRequires: portaudio-devel libiio-devel rtaudio-devel -BuildRequires: spdlog-devel fmt-devel rapidjson-devel json-devel -BuildRequires: stb_image-devel stb_image_resize-devel +BuildRequires: spdlog-devel fmt-devel rapidjson-devel BuildRequires: SoapySDR-devel hackrf-devel rtl-sdr-devel # Bundled libraries # https://github.com/AlexandreRouma/SDRPlusPlus/issues/292 -# https://github.com/ocornut/imgui # MIT License Provides: bundled(imgui) = 1.83 -# https://github.com/samhocevar/portable-file-dialogs -# WTFPL License -Provides: bundled(portable-file-dialogs) = 0.1.0 +# Public Domain +Provides: bundled(stb_image) = 2.26 +# MIT License +# https://github.com/nlohmann/json +Provides: bundled(nlohmann-json) = 3.9.0 # A local copy of libsddc is present in sddc_source but is not built. # A local copy of libcorrect is present in falcon9_decoder but is not built. -# A local copy of nlohmann-json is present in the source and is deleted prior to building. -# A local copy of stb_image and stb_image_resize is present in the source and is deleted prior to building. -# A local copy of rapidjson is present in the source and is deleted prior to building. -# A local copy of spdlog is present in the source and is deleted prior to building. @@ -64,17 +58,8 @@ %prep %autosetup -p1 -n SDRPlusPlus-%{commit} -# Delete local copy of spdlog. We're using the system library copy. +# Delete localy copy of spdlog. We're using the system library copy. rm -rf core/src/spdlog # Delete local copy of rapidjson. We're using the system library copy. rm -rf discord_integration/discord-rpc/include/rapidjson -# Replace use of local nlohmann-json with library version -rm core/src/json.hpp -grep -l -r '#include <json.hpp>' . | xargs sed -i -e 's:#include <json.hpp>:#include <nlohmann/json.hpp>:' -# Replace use of local stb_image and stb_image_resize with library version -rm core/src/imgui/stb_image_resize.h -rm core/src/imgui/stb_image.h -sed -i -e 's:#include <imgui/stb_image.h>:#include <stb/stb_image.h>:' core/src/gui/icons.cpp -sed -i -e 's:#include <stb_image.h>:#include <stb/stb_image.h>:' \ - -e 's:#include <stb_image_resize.h>:#include <stb/stb_image_resize.h>:' core/src/core.cpp %build @@ -85,5 +70,5 @@ %cmake -DOPT_BUILD_AIRSPY_SOURCE=OFF -DOPT_BUILD_AIRSPYHF_SOURCE=OFF \ -DOPT_BUILD_BLADERF_SOURCE=OFF \ - -DOPT_BUILD_PLUTOSDR_SOURCE=OFF \ + -DOPT_BUILD_SPYSERVER_SOURCE=OFF -DOPT_BUILD_PLUTOSDR_SOURCE=OFF \ -DOPT_BUILD_NEW_PORTAUDIO_SINK=ON @@ -92,4 +77,5 @@ %install +rm -rf $RPM_BUILD_ROOT %cmake_install rm %{buildroot}%{_libdir}/libsdrpp_core.so Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2003876 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, R, Ocaml, Haskell, Perl, Python, SugarActivity, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2003876 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
