https://bugzilla.redhat.com/show_bug.cgi?id=2003876 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx --- Comment #4 from Petr Menšík <pemensik@xxxxxxxxxx> --- Hi Matt, any downstream patches should contain links to Merge requests or at least issues filled to upstream. It should be possible to remove them in later releases, their status and upstream acceptance or refusal should be easier to be tracked. imgui [1] seems to be significant project enough to deserve separate package review first, which should block this review. We already have rust bindings to it [2] and four different packages bundling it already: dolphin-emu-0:5.0.13603-3.fc34.x86_64 dolphin-emu-0:5.0.14790-3.fc34.x86_64 mangohud-0:0.6.1-3.fc34.i686 mangohud-0:0.6.1-3.fc34.x86_64 mangohud-0:0.6.5-1.fc34.i686 mangohud-0:0.6.5-1.fc34.x86_64 nextpnr-0:0-0.19.20210307gitf0e30ab.fc34.x86_64 nextpnr-0:0-0.25.20210904gitfd6366f.fc34.x86_64 prusa-slicer-0:2.2.0-11.fc34.x86_64 If that is not enough reason to unbundle it and make separate package, what would be? I guess some of those packages maintainers should be asked for help with that package or at least review. But it seems its upstream does not support any kind of non-static library. It does not even have any build system used. Maybe it is indeed up to best intentions of imgui upstream to be used the current way, even it violates rules of Fedora. License tag has to include MIT and WTFPL, if those two bundled bundled(imgui) and bundled(portable-file-dialogs) are used to build the package. They became part of either library or command present in built RPM. If they are not needed, remove bundled provides. Desktop file is installed, but is not validated [3]. readme.md should be included in %doc, contributing.md also. Problem is with included Roboto-Medium.ttf font. Fedora forbids package included fonts[4]. And it seems the same file is part of google-roboto-fonts package, which should be used instead. Use symlink if required, add Requires: google-roboto-fonts. 1. https://github.com/ocornut/imgui 2. https://src.fedoraproject.org/rpms/rust-imgui 3. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage 4. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_avoid_bundling_of_fonts_in_other_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2003876 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
