[Bug 1998886] Review Request: python-liblarch - Data structures helper library for python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1998886



--- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Miguel from comment #6)
> I do not have a sponsor yet, but someone called Kevin Fenzi said on the
> devel mailing list that they could be my sponsor if they have time, but
> didn't confirmed anything yet.

Okay.  If Kevin doesn't have time, ping me.

> That's the way it is specified here in the "Generating the %files section":
> https://src.fedoraproject.org/rpms/pyproject-rpm-macros

Yes, but that's for a single package.  You're trying to make two packages that
each contain one module, so that approach isn't going to work.

> I tried to split it into two lines and put them before each %files call,
> like this:
> 
> ```
> %pyproject_save_files liblarch
> 
> %files -n python3-liblarch -f %{pyproject_files}
> %license LICENSE
> %doc AUTHORS README.md examples
> 
> 
> %pyproject_save_files liblarch_gtk
> 
> %files -n python3-liblarch-gtk -f %{pyproject_files}
> %license LICENSE
> %doc AUTHORS README.md
> ```
> 
> but I got these errors when running mock:

Right, %pyproject_save_files is a macro that expands to shell code, so it can't
go in %files, which is just a list of files.  Maybe somebody else has a better
idea, but I think you're going to have to use an explicit list of files,
instead of using %pyproject_save_files.

%install
%pyproject_install

...

%files -n python3-liblarch
%license LICENSE
%doc AUTHORS README.md examples
%{python3_sitelib}/liblarch/
%{python3_sitelib}/liblarch-%{version}.dist-info/

%files -n python3-liblarch_gtk
%license LICENSE
%doc AUTHORS README.md
%{python3_sitelib}/liblarch_gtk/

That's not as pretty as the %pyproject_save_files approach, but it works. 
Also, to answer my own questions above:
- Yes, gtk3 seems to be sufficient, rather than gtk3-devel.
- Yes, python3-gobject-base seems to be sufficient, rather than
python3-gobject.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1998886
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux