https://bugzilla.redhat.com/show_bug.cgi?id=1998886 --- Comment #6 from Miguel <miguel7r.araujo@xxxxxxxxx> --- (In reply to Jerry James from comment #3) > (In reply to Miguel from comment #2) > > I updated my spec file to run the tests. I was able to run the test in mock > > and copr without specifying the "PYTHONPATH" variable, so I didn't put it in > > the spec file. > > Sure, for a noarch Python package, that won't matter. > > I will take this review. Do you have a sponsor lined up yet? I do not have a sponsor yet, but someone called Kevin Fenzi said on the devel mailing list that they could be my sponsor if they have time, but didn't confirmed anything yet. (In reply to Jerry James from comment #4) > - The python3-liblarch and python3-liblarch_gtk packages both contain each > other's files. The issue is that there is a single %pyproject_save_files > invocation for both modules, so they get the same file lists via > -f %{pyproject_files}. That's the way it is specified here in the "Generating the %files section": https://src.fedoraproject.org/rpms/pyproject-rpm-macros I tried to split it into two lines and put them before each %files call, like this: ``` %pyproject_save_files liblarch %files -n python3-liblarch -f %{pyproject_files} %license LICENSE %doc AUTHORS README.md examples %pyproject_save_files liblarch_gtk %files -n python3-liblarch-gtk -f %{pyproject_files} %license LICENSE %doc AUTHORS README.md ``` but I got these errors when running mock: ``` + RPM_EC=0 ++ jobs -p + exit 0 Processing files: python3-liblarch-3.1.0-1.fc34.noarch error: File must begin with "/": \ error: File must begin with "/": \ error: File must begin with "/": --output error: File must begin with "/": \ error: File must begin with "/": --buildroot error: File must begin with "/": \ error: File must begin with "/": --sitelib error: File must begin with "/": \ error: File must begin with "/": --sitearch error: File must begin with "/": \ error: File must begin with "/": --python-version error: File must begin with "/": 3.9 error: File must begin with "/": \ error: File must begin with "/": --pyproject-record error: File must begin with "/": \ error: File must begin with "/": liblarch_gtk ``` If I put one line right after the other I got an error with installed but unpackaged files: ``` error: Installed (but unpackaged) file(s) found: /usr/lib/python3.9/site-packages/liblarch/__init__.py /usr/lib/python3.9/site-packages/liblarch/__pycache__/__init__.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/__init__.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filteredtree.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filteredtree.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filters_bank.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filters_bank.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/processqueue.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/processqueue.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/tree.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/tree.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/treenode.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/treenode.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewcount.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewcount.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewtree.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewtree.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/filteredtree.py /usr/lib/python3.9/site-packages/liblarch/filters_bank.py /usr/lib/python3.9/site-packages/liblarch/processqueue.py /usr/lib/python3.9/site-packages/liblarch/tree.py /usr/lib/python3.9/site-packages/liblarch/treenode.py /usr/lib/python3.9/site-packages/liblarch/viewcount.py /usr/lib/python3.9/site-packages/liblarch/viewtree.py Installed (but unpackaged) file(s) found: /usr/lib/python3.9/site-packages/liblarch/__init__.py /usr/lib/python3.9/site-packages/liblarch/__pycache__/__init__.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/__init__.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filteredtree.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filteredtree.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filters_bank.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/filters_bank.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/processqueue.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/processqueue.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/tree.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/tree.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/treenode.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/treenode.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewcount.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewcount.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewtree.cpython-39.opt-1.pyc /usr/lib/python3.9/site-packages/liblarch/__pycache__/viewtree.cpython-39.pyc /usr/lib/python3.9/site-packages/liblarch/filteredtree.py /usr/lib/python3.9/site-packages/liblarch/filters_bank.py /usr/lib/python3.9/site-packages/liblarch/processqueue.py /usr/lib/python3.9/site-packages/liblarch/tree.py /usr/lib/python3.9/site-packages/liblarch/treenode.py /usr/lib/python3.9/site-packages/liblarch/viewcount.py /usr/lib/python3.9/site-packages/liblarch/viewtree.py ``` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1998886 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
