https://bugzilla.redhat.com/show_bug.cgi?id=2004268 --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Jitka Plesnikova from comment #1) > Source file is ok > Summary is ok > License is ok > Description is ok > URL and Source0 are ok > All tests passed > BuildRequires are ok > FIX: Please add BR > - perl(Moo::_Utils) - lib/MooX/TypeTiny.pm:7 The dependency is filtered from perl-Moo package, so it should not be added. > > $ rpm -qp --requires perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | > uniq -c | grep -v rpmlib > 1 perl(:MODULE_COMPAT_5.34.0) > 1 perl(Moo::Role) > 1 perl(Moo::_Utils) FIX: Filter perl(Moo::_Utils) and require Moo which provide the module. > 1 perl(Scalar::Util) > 1 perl(strict) > 1 perl(Sub::Quote) > 1 perl(warnings) > FIX: Please add run-requires > - perl(Moo) >= 2.004000 > - perl(Type::Tiny) >= 1.008000 > > $ rpm -qp --provides perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | > uniq -c > 1 perl(MooX::TypeTiny) = 0.002003 > 1 perl-MooX-TypeTiny = 0.002003-1.fc36 > 1 perl(MooX::TypeTiny::Role::GenerateAccessor) > Binary provides are Ok. > > $ rpmlint ./perl-MooX-TypeTiny* > perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US isa -> > is, visa, Lisa > perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US coercions > -> coercion, coercion's, coercion s > perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is, > visa, Lisa > perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions -> > coercion, coercion's, coercion s > 2 packages and 1 specfiles checked; 0 errors, 4 warnings. > Rpmlint is ok > > Otherwise the package is in line with Fedora and Perl packaging guide lines. > Please correct all 'FIX' items. > > Resolution: > Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2004268 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
