https://bugzilla.redhat.com/show_bug.cgi?id=2004268 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok FIX: Please add BR - perl(Moo::_Utils) - lib/MooX/TypeTiny.pm:7 $ rpm -qp --requires perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Moo::Role) 1 perl(Moo::_Utils) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Quote) 1 perl(warnings) FIX: Please add run-requires - perl(Moo) >= 2.004000 - perl(Type::Tiny) >= 1.008000 $ rpm -qp --provides perl-MooX-TypeTiny-0.002003-1.fc36.noarch.rpm | sort | uniq -c 1 perl(MooX::TypeTiny) = 0.002003 1 perl-MooX-TypeTiny = 0.002003-1.fc36 1 perl(MooX::TypeTiny::Role::GenerateAccessor) Binary provides are Ok. $ rpmlint ./perl-MooX-TypeTiny* perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US isa -> is, visa, Lisa perl-MooX-TypeTiny.noarch: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US isa -> is, visa, Lisa perl-MooX-TypeTiny.src: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2004268 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure