https://bugzilla.redhat.com/show_bug.cgi?id=1997378 --- Comment #12 from Michal Schorm <mschorm@xxxxxxxxxx> --- Looks good, thanks for the justifications ! --- I won't accept this piece of code: | # To allow error-less build without packing llvmjit | %if %{without llvmjit} | %define _unpackaged_files_terminate_build 0 | %endif If possible, please avoid modifying the natural build process. When you have a known list of unpacked files, remove them in in %install phase instead. That way you will still be informed, when a new unexpected file become unpacked to ! When using 'rm', do not use '-f'; for the same reason. As long as you can precisely list all file to be affected by the command, let the command stop you with it's natural behaviour (e.g. "hey, I should have removed a file but it is not there after the last rebase, what should I do?") The very same idea is the reason why the Guidelines prohibits concealing shared libraries version number with a globs / wildcards. So the natural build process would let you know in the future, that something needs your attention. Please keep this idea in mind during your maintainer life. --- Issue found by fedora-review tool: 1/ If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ 2/ License file installed when any subpackage combination is installed. We overlooked this one in the last iteration. The 'docs' subpackage> Requires: %{name}%{?_isa} = %precise_version was taking care of this. Either put it back, or move the license file to a standalone subpackage which will be required by all other subpackages. 3/ Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pgsql/bitcode/pgautofailover Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/pgsql/bitcode/pgautofailover, /usr/lib64/pgsql/bitcode -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1997378 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
