https://bugzilla.redhat.com/show_bug.cgi?id=1997378 --- Comment #11 from mkulik@xxxxxxxxxx --- 1. Fixed trailing spaces. 2. Yes, I agree. 3. Update spec file to 1.6.2. (bug fix release) (new issues, look docs section) Another Changes: * Fixed cond macros for sub-pkgs builds. Now, all builds correctly. * Description for openssl-devel added. * Added _unpackaged_files_terminate_build (This is only activated when we build without jit extension, I would not put it in default build but for conditional, not default arguments should be fine, avoiding not packed JIT extensions) * Switch to bcond About man files: I know that removing spaces is not a great solution here but this is not a problem on my side. Assuming that spaces in man files are allowed, example 'autopl example.1' those files should be compressed by %install macro, they are not because of this: https://github.com/rpm-software-management/rpm/blob/master/scripts/brp-compress#L24 this script won't handle files with special characters correctly. I will try to solve it in upstream but that will take time and I need to choose workaround for now. Here are my options: - change spaces to '-' or '_' to satisfy brp script. - compress man files manually in spec %install macro - try to modify sources to generate names without spaces (Not a great solution probably) - add compression to Makefile in sources using patch file I choose the 1st one, it seems like a good compromise until bug is fixed. Last option also looks ok-ish but it will require more changes and it is more pron to errors in the future (additional patch file). About docs: - Added %doc macro. - upstream started using sphinx_rtd_theme_citus (fork of sphinx_rtd_theme). I reverted it to official version using patch file. More comments in patch file. - Fix files wildcard (compression .gz) SPEC: https://gist.githubusercontent.com/mkulik-rh/0899b8f07bb6fabeee0c7a94e7b8d340/raw/30a0fa9b3c890995830239808929f1296f6a0afa/pg_auto_failover.spec Patch0: https://gist.githubusercontent.com/mkulik-rh/ace6f65a9bef641860e93bea7bbd0e78/raw/bf454e9687f5cf3d5ac9bb14d70ee06fc7abb57a/gistfile1.txt SRPM: https://copr-be.cloud.fedoraproject.org/results/mkulik/pg_auto_failover/srpm-builds/02742729/pg_auto_failover-1.6.2-1.fc35.src.rpm https://copr.fedorainfracloud.org/coprs/mkulik/pg_auto_failover/builds/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1997378 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
